Sorry for the stupid question, but i'm just looking for another set of eyes, perhaps someone can tell me how can i get this going...

String mystring="";
void setup()
{
Serial.begin(9600);
}

void loop()
{
mystring="The ADC value is: " + analogRead(A15);
Serial.println(mystring);
sendlog(mystring);
delay(10000);
}

void sendlog(const char* message)
{
//do whatever to send this to logging SD...
}

while compiling, i get the following: 

error: cannot convert 'String' to 'const char*' for argument '1' to 'void sendlog(const char*)'

I understand, this is an expected error, but how to i fix this? i want to get away from using String object altogether. The sendlog is a part of other library, which i do not want to modify, but looking to fix my code instead... Anyone has any idea? I tried all different option starting from .toCharArray and ending with strcpy and alike to fix this, but it seems, that nothing is being passed to the sendlog in the end. so, i need to append a string of characters with int, and send it to the sendlog as a char*. This must be very simple, and this is one of those, where i do not seem so see a very obvious solution... Help anyone?

--Andy

Views: 2920

Reply to This

Replies to This Discussion

First, if you try to append a non-string value to a string it'll get weird.  Instead of

mystring="The ADC value is: " + analogRead(A15);

you should use

mystring="The ADC value is: " + String(analogRead(A15), DEC);

to append a new String (created from a decimal value) to your existing String.  Note that the original method won't cause a compile error, but what you get over the serial port will likely be garbage.  (What you're doing is adding the value read from the analog port to the memory location of mystring, and it'll pass that to println which will read from that incorrect point until it encounters a null byte.)

Second, you have to break the String object back to an array of chars, and to do that you have to have an array of chars to put it in.  If you know what the length of your string is going to be, or at least some sort of maximum range, it's pretty easy.  We know that your string will only be 23 characters long ("The ADC value is: " = 18, "1023" [the max analogRead() value] = 4, and one extra for the terminating null character), so our array only has to be that big.  If you change the wording you'll have to resize the array.

char otherString[23]; //char array to copy the String into

mystring.toCharArray(otherstring, mystring.length() + 1); //Copy the string (+1 is to hold the terminating null char)

sendlog(otherString); //send our char array copy of the String object to sendlog()

Char arrays don't offer all the flexibility that a String object does, and they're sometimes kind of hard to work with, but they're a lot smaller and faster (they only take up as much space as there are characters).

I hope this helps you out.  You could achieve the same outcome using only a char array, but the String object is so much easier to use, especially for converting a number to a string and appending one string to another.

I keep reading in the Arduino reference that you can use "Constant String" + analogRead(), myString += 123, and similar constructions, but whenever I do I get random-length garbage.  Using the String constructor to concatenate a number to a string works though.  Who knows.

RSS

Latest Activity

Jim Kelley joined Marcelo Rodrigues's group
Thumbnail

Arduino

Group for the Arduino communitySee More
3 hours ago
Jim Kelley posted a discussion

Help with selecting sensors

I am new to Arduino but am a quick study and can get up to speed fast. I can see some tremendous…See More
4 hours ago
GarageLab posted a blog post

These 3D-Printed Ants Could Be The Factory Workers Of The Future

These 3D-printed ants scuttle around much like the real thing. But loaded with sensors and wireless…See More
4 hours ago
Profile IconAdele Smurthwaite, Neil Cheng, John Hardie and 1 more joined GarageLab (arduino, electronics, robotics, hacking)
5 hours ago
GarageLab posted blog posts
Friday
Profile IconOleg and Scott Runner joined GarageLab (arduino, electronics, robotics, hacking)
Thursday
GarageLab left a comment for RMullen
"Hi RMullen! I'd like to let you know that FRANK KWABENA is no longer a member of…"
Wednesday
daniel gabriel updated their profile
Wednesday
daniel gabriel left a comment for daniel gabriel
"Good Day Mr. Wabena, i dont see any interesting on my profile but i really appreciated that you…"
Wednesday
RMullen replied to Lauren Elizabeth's discussion Scammed...?
"Yes there is another one sending out the same message now.  This is the message I got: FRANK…"
Wednesday
Rick Lin is now a member of GarageLab (arduino, electronics, robotics, hacking)
Wednesday
GarageLab posted a blog post
Tuesday
Profile IconCalvin M and harsha joined GarageLab (arduino, electronics, robotics, hacking)
Mar 24
GarageLab posted a blog post

These Colorful Liquid Droplets Chase Each Other Like Living Organisms

Scientists at Stanford University were at first perplexed by the strange behavior they observed…See More
Mar 23
GarageLab posted blog posts
Mar 20
Profile IconJody Bowie, Kevin Kvarda, Tony Stoklosa and 2 more joined GarageLab (arduino, electronics, robotics, hacking)
Mar 19
Sergey commented on GarageLab's blog post Tutorial: How to use the Monster Moto Shield
"Good day. Can you help me? I took this sketch, but it doesn't working( "
Mar 19
Profile IconDonald Soji Adedokun, Ankur Deo and Hannu Miettinen joined GarageLab (arduino, electronics, robotics, hacking)
Mar 18
GarageLab posted a blog post
Mar 18
GarageLab posted a blog post

Iron Man Delivers Kid’s Robotic Arm: Proof that Tony Stark Has a Heart

Alex Pring now has one heck of a story to tell his friends. Not only did the 7-year old meet Iron…See More
Mar 16

© 2015   Created by Marcelo Rodrigues.

Badges  |  Report an Issue  |  Terms of Service