Sorry for the stupid question, but i'm just looking for another set of eyes, perhaps someone can tell me how can i get this going...

String mystring="";
void setup()
{
Serial.begin(9600);
}

void loop()
{
mystring="The ADC value is: " + analogRead(A15);
Serial.println(mystring);
sendlog(mystring);
delay(10000);
}

void sendlog(const char* message)
{
//do whatever to send this to logging SD...
}

while compiling, i get the following: 

error: cannot convert 'String' to 'const char*' for argument '1' to 'void sendlog(const char*)'

I understand, this is an expected error, but how to i fix this? i want to get away from using String object altogether. The sendlog is a part of other library, which i do not want to modify, but looking to fix my code instead... Anyone has any idea? I tried all different option starting from .toCharArray and ending with strcpy and alike to fix this, but it seems, that nothing is being passed to the sendlog in the end. so, i need to append a string of characters with int, and send it to the sendlog as a char*. This must be very simple, and this is one of those, where i do not seem so see a very obvious solution... Help anyone?

--Andy

Views: 4201

Reply to This

Replies to This Discussion

First, if you try to append a non-string value to a string it'll get weird.  Instead of

mystring="The ADC value is: " + analogRead(A15);

you should use

mystring="The ADC value is: " + String(analogRead(A15), DEC);

to append a new String (created from a decimal value) to your existing String.  Note that the original method won't cause a compile error, but what you get over the serial port will likely be garbage.  (What you're doing is adding the value read from the analog port to the memory location of mystring, and it'll pass that to println which will read from that incorrect point until it encounters a null byte.)

Second, you have to break the String object back to an array of chars, and to do that you have to have an array of chars to put it in.  If you know what the length of your string is going to be, or at least some sort of maximum range, it's pretty easy.  We know that your string will only be 23 characters long ("The ADC value is: " = 18, "1023" [the max analogRead() value] = 4, and one extra for the terminating null character), so our array only has to be that big.  If you change the wording you'll have to resize the array.

char otherString[23]; //char array to copy the String into

mystring.toCharArray(otherstring, mystring.length() + 1); //Copy the string (+1 is to hold the terminating null char)

sendlog(otherString); //send our char array copy of the String object to sendlog()

Char arrays don't offer all the flexibility that a String object does, and they're sometimes kind of hard to work with, but they're a lot smaller and faster (they only take up as much space as there are characters).

I hope this helps you out.  You could achieve the same outcome using only a char array, but the String object is so much easier to use, especially for converting a number to a string and appending one string to another.

I keep reading in the Arduino reference that you can use "Constant String" + analogRead(), myString += 123, and similar constructions, but whenever I do I get random-length garbage.  Using the String constructor to concatenate a number to a string works though.  Who knows.

RSS

Latest Activity

GarageLab posted blog posts
22 hours ago
Gaston Lieutier is now a member of GarageLab (arduino, electronics, robotics, hacking)
yesterday
Volkan Coskun posted a discussion

Problem with my motordriver and dc motor

GarageLab enthusiasts!I am trying to build a balancing robot with two wheels, using the polulu gear…See More
Monday
GarageLab posted a blog post
Monday
Profile IconHugo Saffir and Volkan Coskun joined GarageLab (arduino, electronics, robotics, hacking)
Monday
GarageLab posted blog posts
Friday
Profile IconJoseph Long and Pablo Costas joined GarageLab (arduino, electronics, robotics, hacking)
Jul 23
GarageLab posted blog posts
Jul 22
Profile Iconvictor ghenno, Michel Souza Medeiros, ANAND S and 6 more joined GarageLab (arduino, electronics, robotics, hacking)
Jul 21
GarageLab posted blog posts
Jul 20
Chris replied to Chris's discussion Newbie question ......suitable power supply
"I just had a reply on another forum does this make sense? "The device you purchased is not…"
Jul 16
Profile IconPedro A Vazquez, Dylan, Feliks Gadzinski and 1 more joined GarageLab (arduino, electronics, robotics, hacking)
Jul 16
Chris posted a discussion

Newbie question ......suitable power supply

Hi guysFirstly I have no knowledge whatsoever of Electronics and RF, my background back in the UK…See More
Jul 16
GarageLab posted a blog post

Micro:Bit — BBC gets a million kids into embedded dev

In the Early 1980s, the BBC launched a project to teach computer literacy to a generation of…See More
Jul 16
Profile IconDavid Bissonnette, Bob Blanco, Mark Pind and 4 more joined GarageLab (arduino, electronics, robotics, hacking)
Jul 15
GarageLab posted blog posts
Jul 15
Phan Minh Kha commented on Thulana Vimukthi's blog post GPS GUIDED AUTONOMOUS ROBOT
"bool condition = ((angleDegrees -10) < headingDegrees) && ((angleDegrees +10) >…"
Jul 14
Phan Minh Kha commented on Thulana Vimukthi's blog post GPS GUIDED AUTONOMOUS ROBOT
"dist_calc=sqrt((((flon1)-(x2lon))*((flon1)-(x2lon)))+(((x2lat-flat1)*(x2lat-flat1))));…"
Jul 14
GarageLab posted blog posts
Jul 13
GarageLab posted blog posts
Jul 8

© 2015   Created by Marcelo Rodrigues.

Badges  |  Report an Issue  |  Terms of Service