Sorry for the stupid question, but i'm just looking for another set of eyes, perhaps someone can tell me how can i get this going...

String mystring="";
void setup()
{
Serial.begin(9600);
}

void loop()
{
mystring="The ADC value is: " + analogRead(A15);
Serial.println(mystring);
sendlog(mystring);
delay(10000);
}

void sendlog(const char* message)
{
//do whatever to send this to logging SD...
}

while compiling, i get the following: 

error: cannot convert 'String' to 'const char*' for argument '1' to 'void sendlog(const char*)'

I understand, this is an expected error, but how to i fix this? i want to get away from using String object altogether. The sendlog is a part of other library, which i do not want to modify, but looking to fix my code instead... Anyone has any idea? I tried all different option starting from .toCharArray and ending with strcpy and alike to fix this, but it seems, that nothing is being passed to the sendlog in the end. so, i need to append a string of characters with int, and send it to the sendlog as a char*. This must be very simple, and this is one of those, where i do not seem so see a very obvious solution... Help anyone?

--Andy

Views: 1098

Reply to This

Replies to This Discussion

First, if you try to append a non-string value to a string it'll get weird.  Instead of

mystring="The ADC value is: " + analogRead(A15);

you should use

mystring="The ADC value is: " + String(analogRead(A15), DEC);

to append a new String (created from a decimal value) to your existing String.  Note that the original method won't cause a compile error, but what you get over the serial port will likely be garbage.  (What you're doing is adding the value read from the analog port to the memory location of mystring, and it'll pass that to println which will read from that incorrect point until it encounters a null byte.)

Second, you have to break the String object back to an array of chars, and to do that you have to have an array of chars to put it in.  If you know what the length of your string is going to be, or at least some sort of maximum range, it's pretty easy.  We know that your string will only be 23 characters long ("The ADC value is: " = 18, "1023" [the max analogRead() value] = 4, and one extra for the terminating null character), so our array only has to be that big.  If you change the wording you'll have to resize the array.

char otherString[23]; //char array to copy the String into

mystring.toCharArray(otherstring, mystring.length() + 1); //Copy the string (+1 is to hold the terminating null char)

sendlog(otherString); //send our char array copy of the String object to sendlog()

Char arrays don't offer all the flexibility that a String object does, and they're sometimes kind of hard to work with, but they're a lot smaller and faster (they only take up as much space as there are characters).

I hope this helps you out.  You could achieve the same outcome using only a char array, but the String object is so much easier to use, especially for converting a number to a string and appending one string to another.

I keep reading in the Arduino reference that you can use "Constant String" + analogRead(), myString += 123, and similar constructions, but whenever I do I get random-length garbage.  Using the String constructor to concatenate a number to a string works though.  Who knows.

RSS

Latest Activity

Profile IconCeline Buline Forma and Gilmar Barbosa joined GarageLab (arduino, electronics, robotics, hacking)
9 hours ago
Gilmar Barbosa replied to GarageLab's discussion Show your lab!
17 hours ago
GarageLab posted blog posts
19 hours ago
Profile IconMichael Tria, Carl C Sartin and Oswaldo Machado joined GarageLab (arduino, electronics, robotics, hacking)
yesterday
GarageLab posted a blog post

Pressure Gauge Modded to Measure Internet Usage

The appeal of having a 100 year old gauge on the wall that shows the current Internet usage is hard…See More
Monday
GarageLab posted blog posts
Friday
Profile IconAngelo Zanellato and Allan Byres joined GarageLab (arduino, electronics, robotics, hacking)
Aug 21
Shannon Bradley commented on GarageLab's blog post Company creates device that recharges smartphones ultrasound
" I have been having good results out too ten to twenty miles. I'm about to fix this…"
Aug 21
GarageLab posted blog posts
Aug 21
Marcelo Rodrigues commented on Marcelo Rodrigues's blog post Arduino generated VGA (color) signal - Complete!
"Jay, Here it is. Enjoy! "
Aug 20
Jay Curtis commented on Marcelo Rodrigues's blog post Arduino generated VGA (color) signal - Complete!
"Hey, great stuff! Found this site through searching for a solution to get VGA to work with LCD and…"
Aug 20
GarageLab posted a blog post

Omote uses light to project virtual makeup and real-time animations on your face

A team of artists and computer graphics designers have created a projection mapping system that you…See More
Aug 19
Jay Curtis is now a member of GarageLab (arduino, electronics, robotics, hacking)
Aug 19
GarageLab posted blog posts
Aug 18
GarageLab posted blog posts
Aug 14
Tony Warren posted a photo
Aug 13
Dmitriy Zelinskiy joined Marcelo Rodrigues's group
Thumbnail

Arduino

Group for the Arduino communitySee More
Aug 12
Profile IconMike Hutchings, Dmitriy Zelinskiy and blake tony joined GarageLab (arduino, electronics, robotics, hacking)
Aug 12
GarageLab posted blog posts
Aug 12
Siti Normah is now a member of GarageLab (arduino, electronics, robotics, hacking)
Aug 11

© 2014   Created by Marcelo Rodrigues.

Badges  |  Report an Issue  |  Terms of Service