Sorry for the stupid question, but i'm just looking for another set of eyes, perhaps someone can tell me how can i get this going...

String mystring="";
void setup()
{
Serial.begin(9600);
}

void loop()
{
mystring="The ADC value is: " + analogRead(A15);
Serial.println(mystring);
sendlog(mystring);
delay(10000);
}

void sendlog(const char* message)
{
//do whatever to send this to logging SD...
}

while compiling, i get the following: 

error: cannot convert 'String' to 'const char*' for argument '1' to 'void sendlog(const char*)'

I understand, this is an expected error, but how to i fix this? i want to get away from using String object altogether. The sendlog is a part of other library, which i do not want to modify, but looking to fix my code instead... Anyone has any idea? I tried all different option starting from .toCharArray and ending with strcpy and alike to fix this, but it seems, that nothing is being passed to the sendlog in the end. so, i need to append a string of characters with int, and send it to the sendlog as a char*. This must be very simple, and this is one of those, where i do not seem so see a very obvious solution... Help anyone?

--Andy

Views: 3984

Reply to This

Replies to This Discussion

First, if you try to append a non-string value to a string it'll get weird.  Instead of

mystring="The ADC value is: " + analogRead(A15);

you should use

mystring="The ADC value is: " + String(analogRead(A15), DEC);

to append a new String (created from a decimal value) to your existing String.  Note that the original method won't cause a compile error, but what you get over the serial port will likely be garbage.  (What you're doing is adding the value read from the analog port to the memory location of mystring, and it'll pass that to println which will read from that incorrect point until it encounters a null byte.)

Second, you have to break the String object back to an array of chars, and to do that you have to have an array of chars to put it in.  If you know what the length of your string is going to be, or at least some sort of maximum range, it's pretty easy.  We know that your string will only be 23 characters long ("The ADC value is: " = 18, "1023" [the max analogRead() value] = 4, and one extra for the terminating null character), so our array only has to be that big.  If you change the wording you'll have to resize the array.

char otherString[23]; //char array to copy the String into

mystring.toCharArray(otherstring, mystring.length() + 1); //Copy the string (+1 is to hold the terminating null char)

sendlog(otherString); //send our char array copy of the String object to sendlog()

Char arrays don't offer all the flexibility that a String object does, and they're sometimes kind of hard to work with, but they're a lot smaller and faster (they only take up as much space as there are characters).

I hope this helps you out.  You could achieve the same outcome using only a char array, but the String object is so much easier to use, especially for converting a number to a string and appending one string to another.

I keep reading in the Arduino reference that you can use "Constant String" + analogRead(), myString += 123, and similar constructions, but whenever I do I get random-length garbage.  Using the String constructor to concatenate a number to a string works though.  Who knows.

RSS

Latest Activity

tools4u posted discussions
yesterday
Profile IconRichard Vincent, KrisWiner and tools4u joined GarageLab (arduino, electronics, robotics, hacking)
Friday
GarageLab posted blog posts
Wednesday
Profile IconJ.J.J. Kuipers and Phan Minh Kha joined GarageLab (arduino, electronics, robotics, hacking)
Wednesday
GarageLab posted a blog post

Electric lawn mower converted to RC control

Not too many people like pushing a lawn mower around the yard, but unfortunately, it is a necessary…See More
Jun 29
Profile Iconchiran sachintha and Blun Blun joined GarageLab (arduino, electronics, robotics, hacking)
Jun 29
GarageLab posted a blog post

Codename Colossus: The HMC Boudicca

[Michael Sng], founder of [Machination Studio], wanted to create a toy line unlike anything the…See More
Jun 26
Fernando Rodrigues Pontes is now a member of GarageLab (arduino, electronics, robotics, hacking)
Jun 26
GarageLab posted blog posts
Jun 23
Profile IconSayed Akbar Rajaei Ramsheh, william sarte and Ahmed OUKERROUM joined GarageLab (arduino, electronics, robotics, hacking)
Jun 23
GarageLab posted a blog post

Dashboard in you simulator!

 Fans of driving simulator games not only play with steering wheels, gear shifters and pedals. Some…See More
Jun 22
Jesus M Andino commented on GarageLab's blog post Diabetes Has a New Enemy: Robo-Pancreas
"How will be the sugar regulated when there is a higher demand of it due to stress situations? "
Jun 19
GarageLab posted blog posts
Jun 19
GarageLab posted blog posts
Jun 17
AnalysIR posted a blog post

Porting AnalysIR firmware to Particle’s Photon platform

We have just finished porting our (single source) firmware from a range of other ‘Arduino’ type…See More
Jun 17
Profile Iconabin joseph, ATony and cocowei joined GarageLab (arduino, electronics, robotics, hacking)
Jun 17
Michael updated their profile
Jun 15
lovakiranvarma replied to Kringen's discussion MSP430 Launch Pad
"hi! Kringen even though Energia is promissing! But in my opinion it won't much helpful…"
Jun 14
GarageLab posted a blog post
Jun 12
AnalysIR posted a blog post

Simple Infrared PWM on Arduino, Part 2- RAW IR Signals

In Part 1 of this series, we demonstrated how to send signals using simple Infrared PWM on Arduino.…See More
Jun 12

© 2015   Created by Marcelo Rodrigues.

Badges  |  Report an Issue  |  Terms of Service