Sorry for the stupid question, but i'm just looking for another set of eyes, perhaps someone can tell me how can i get this going...

String mystring="";
void setup()
{
Serial.begin(9600);
}

void loop()
{
mystring="The ADC value is: " + analogRead(A15);
Serial.println(mystring);
sendlog(mystring);
delay(10000);
}

void sendlog(const char* message)
{
//do whatever to send this to logging SD...
}

while compiling, i get the following: 

error: cannot convert 'String' to 'const char*' for argument '1' to 'void sendlog(const char*)'

I understand, this is an expected error, but how to i fix this? i want to get away from using String object altogether. The sendlog is a part of other library, which i do not want to modify, but looking to fix my code instead... Anyone has any idea? I tried all different option starting from .toCharArray and ending with strcpy and alike to fix this, but it seems, that nothing is being passed to the sendlog in the end. so, i need to append a string of characters with int, and send it to the sendlog as a char*. This must be very simple, and this is one of those, where i do not seem so see a very obvious solution... Help anyone?

--Andy

Views: 9203

Reply to This

Replies to This Discussion

First, if you try to append a non-string value to a string it'll get weird.  Instead of

mystring="The ADC value is: " + analogRead(A15);

you should use

mystring="The ADC value is: " + String(analogRead(A15), DEC);

to append a new String (created from a decimal value) to your existing String.  Note that the original method won't cause a compile error, but what you get over the serial port will likely be garbage.  (What you're doing is adding the value read from the analog port to the memory location of mystring, and it'll pass that to println which will read from that incorrect point until it encounters a null byte.)

Second, you have to break the String object back to an array of chars, and to do that you have to have an array of chars to put it in.  If you know what the length of your string is going to be, or at least some sort of maximum range, it's pretty easy.  We know that your string will only be 23 characters long ("The ADC value is: " = 18, "1023" [the max analogRead() value] = 4, and one extra for the terminating null character), so our array only has to be that big.  If you change the wording you'll have to resize the array.

char otherString[23]; //char array to copy the String into

mystring.toCharArray(otherstring, mystring.length() + 1); //Copy the string (+1 is to hold the terminating null char)

sendlog(otherString); //send our char array copy of the String object to sendlog()

Char arrays don't offer all the flexibility that a String object does, and they're sometimes kind of hard to work with, but they're a lot smaller and faster (they only take up as much space as there are characters).

I hope this helps you out.  You could achieve the same outcome using only a char array, but the String object is so much easier to use, especially for converting a number to a string and appending one string to another.

I keep reading in the Arduino reference that you can use "Constant String" + analogRead(), myString += 123, and similar constructions, but whenever I do I get random-length garbage.  Using the String constructor to concatenate a number to a string works though.  Who knows.

RSS

Latest Activity

sujeeth senthilvel is now a member of GarageLab (arduino, electronics, robotics, hacking)
Friday
Alan commented on Kevin Krumwiede's group Aquaponics
"Joined this group as my main interest in aquaponics much more than electronics !!! However I not…"
Jun 15
Alan joined Kevin Krumwiede's group
Thumbnail

Aquaponics

Ancient agriculture and aquaculture techniques meet modern technology! Learn how to grow fresh…See More
Jun 15
Profile IconKambiz Hadzad and Kasim Rafiq joined GarageLab (arduino, electronics, robotics, hacking)
Jun 15
Marcelo Rodrigues posted a blog post
Jun 14
Michael Williams updated their profile
Jun 13
Joe Mallat is now a member of GarageLab (arduino, electronics, robotics, hacking)
Jun 12
Profile IconCarlos Bejar Marambio, Harsh and Mohammed Mazed Hossain joined GarageLab (arduino, electronics, robotics, hacking)
Jun 10
Marcelo Rodrigues posted a blog post
Jun 9
Marcelo Rodrigues replied to Marc Stevens's discussion easy drive
"Maybe the time between the steps? Do you hear any sound like vibration or noise? If we use a time…"
Jun 8
Profile IconDon Girvin and Michael Williams joined GarageLab (arduino, electronics, robotics, hacking)
Jun 8
Marcelo Rodrigues replied to Peter Davies's discussion Anyone got stock of Garagelabs automation board
";-) Thanks!"
Jun 8
Peter Davies replied to Peter Davies's discussion Anyone got stock of Garagelabs automation board
"Thanks Marcello - placed an order for 10 units today"
Jun 7
Marc Stevens replied to Marc Stevens's discussion easy drive
"I tried every combination of wiring the stepper motor, but it simply don't work. But the motor…"
Jun 7
Marcelo Rodrigues replied to Peter Davies's discussion Anyone got stock of Garagelabs automation board
"Peter, If you still need the ABs, Seeed finally made them available. Thanks!"
Jun 7
Profile Iconnaibin paul, rbk12456 and Dariusz Jasiński joined GarageLab (arduino, electronics, robotics, hacking)
Jun 7
Profile IconM.Hess and ratno wijaya joined GarageLab (arduino, electronics, robotics, hacking)
Jun 3
Mohamed Hammad is now a member of GarageLab (arduino, electronics, robotics, hacking)
Jun 2
Marcelo Rodrigues replied to Marc Stevens's discussion easy drive
"Marc, Check the connections like the following image: If the problem persists, you can check the…"
Jun 2
Marcelo Rodrigues replied to Christine C's discussion The Spam.
"Thank you Jeff. That guy was suspended. Best!"
Jun 2

© 2016   Created by Marcelo Rodrigues.   Powered by

Badges  |  Report an Issue  |  Terms of Service