Sorry for the stupid question, but i'm just looking for another set of eyes, perhaps someone can tell me how can i get this going...

String mystring="";
void setup()
{
Serial.begin(9600);
}

void loop()
{
mystring="The ADC value is: " + analogRead(A15);
Serial.println(mystring);
sendlog(mystring);
delay(10000);
}

void sendlog(const char* message)
{
//do whatever to send this to logging SD...
}

while compiling, i get the following: 

error: cannot convert 'String' to 'const char*' for argument '1' to 'void sendlog(const char*)'

I understand, this is an expected error, but how to i fix this? i want to get away from using String object altogether. The sendlog is a part of other library, which i do not want to modify, but looking to fix my code instead... Anyone has any idea? I tried all different option starting from .toCharArray and ending with strcpy and alike to fix this, but it seems, that nothing is being passed to the sendlog in the end. so, i need to append a string of characters with int, and send it to the sendlog as a char*. This must be very simple, and this is one of those, where i do not seem so see a very obvious solution... Help anyone?

--Andy

Views: 11629

Reply to This

Replies to This Discussion

First, if you try to append a non-string value to a string it'll get weird.  Instead of

mystring="The ADC value is: " + analogRead(A15);

you should use

mystring="The ADC value is: " + String(analogRead(A15), DEC);

to append a new String (created from a decimal value) to your existing String.  Note that the original method won't cause a compile error, but what you get over the serial port will likely be garbage.  (What you're doing is adding the value read from the analog port to the memory location of mystring, and it'll pass that to println which will read from that incorrect point until it encounters a null byte.)

Second, you have to break the String object back to an array of chars, and to do that you have to have an array of chars to put it in.  If you know what the length of your string is going to be, or at least some sort of maximum range, it's pretty easy.  We know that your string will only be 23 characters long ("The ADC value is: " = 18, "1023" [the max analogRead() value] = 4, and one extra for the terminating null character), so our array only has to be that big.  If you change the wording you'll have to resize the array.

char otherString[23]; //char array to copy the String into

mystring.toCharArray(otherstring, mystring.length() + 1); //Copy the string (+1 is to hold the terminating null char)

sendlog(otherString); //send our char array copy of the String object to sendlog()

Char arrays don't offer all the flexibility that a String object does, and they're sometimes kind of hard to work with, but they're a lot smaller and faster (they only take up as much space as there are characters).

I hope this helps you out.  You could achieve the same outcome using only a char array, but the String object is so much easier to use, especially for converting a number to a string and appending one string to another.

I keep reading in the Arduino reference that you can use "Constant String" + analogRead(), myString += 123, and similar constructions, but whenever I do I get random-length garbage.  Using the String constructor to concatenate a number to a string works though.  Who knows.

RSS

Latest Activity

Marcelo Rodrigues and swapnil are now friends
Tuesday
Marcelo Rodrigues replied to swapnil's discussion Tiny 85 based Thermometer
"Dear Swapnil, Since you don't have any experience with programming you should consider start…"
Monday
swapnil posted a discussion

Tiny 85 based Thermometer

Hi, can any one guide me how to make the tiny 85 based Thermometer which will glow the LED…See More
Sunday
Spyros Svoronos is now a member of GarageLab (arduino, electronics, robotics, hacking)
Sunday
K Biju is now a member of GarageLab (arduino, electronics, robotics, hacking)
Nov 29
Profile Iconswapnil and Yasser joined GarageLab (arduino, electronics, robotics, hacking)
Nov 28
udit is now a member of GarageLab (arduino, electronics, robotics, hacking)
Nov 25
Aqeel munir is now a member of GarageLab (arduino, electronics, robotics, hacking)
Nov 23
Profile IconSubbu and Graymon Cadiente joined GarageLab (arduino, electronics, robotics, hacking)
Nov 21
Tim Walller is now a member of GarageLab (arduino, electronics, robotics, hacking)
Nov 18
Dmitry Slepov posted a blog post

Open Platform Communications Server from Tibbo

OPC stands for «Open Platform Communications» that is a set of specifications and standards for…See More
Nov 17
Hrithik Bansal is now a member of GarageLab (arduino, electronics, robotics, hacking)
Nov 17
Martin Tavarez is now a member of GarageLab (arduino, electronics, robotics, hacking)
Nov 14
Brian Sivils is now a member of GarageLab (arduino, electronics, robotics, hacking)
Nov 7
Keren Fi is now a member of GarageLab (arduino, electronics, robotics, hacking)
Nov 3
Profile IconHENRY NUNES and evilhacker joined GarageLab (arduino, electronics, robotics, hacking)
Oct 31
Profile IconJames Pearce and caca joined GarageLab (arduino, electronics, robotics, hacking)
Oct 27
Profile IconWilliam Johnson and Todd Enger joined GarageLab (arduino, electronics, robotics, hacking)
Oct 24
Carlos Kwiek posted a blog post

ESP8266_MQTT_LAMP_ON_OFF

Turning on and off a lamp on the internet and smartphone using ESP8266 with MQTT languageThank you…See More
Oct 24
Avtar Singh is now a member of GarageLab (arduino, electronics, robotics, hacking)
Oct 20

© 2016   Created by Marcelo Rodrigues.   Powered by

Badges  |  Report an Issue  |  Terms of Service